Make CldrCalendar trait sealed except with experimental feature #4392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested review from
zbraniecki,
gregtatum and
nordzilla
as code owners
sffc
requested review from
Manishearth and
robertbastian
and removed request for
zbraniecki,
gregtatum and
nordzilla
Manishearth
previously approved these changes
Nov 30, 2023
Manishearth
previously approved these changes
Dec 1, 2023
components/datetime/src/calendar.rs
Outdated
| @@ -251,6 +264,23 @@ impl CldrCalendar for Roc { | |||
| type MonthSymbolsV1Marker = RocMonthSymbolsV1Marker; | |||
| } | |||
|
|
|||
| impl UnstableCldrCalendar for Buddhist {} | |||
There was a problem hiding this comment.
hmm, this will show up on docs, which we build with all features, and look like Buddhist is an unstable calendar. Maybe call this InternalCldrCalendar?
Manishearth
approved these changes
Dec 5, 2023
|
changelog? |
sffc
added a commit
that referenced
this pull request
Dec 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4341