-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Option
on FFI
#4635
Using Option
on FFI
#4635
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't land this until 2.0
Do you consider this breaking in JS? I'm happy to change the CPP1 generator to translate |
I'm personally ok with breaking JS. I'll leave it up to @sffc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JS change is breaking but the TS should help and I think we don't have very many JS users and the impacted functions are sufficiently in the corner that I'm okay with a changelog notice
This is ABI compatible but API breaking in C++ and arguably JS.