Add impl<T> Writeable for [T] #4790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
commented
Apr 10, 2024
Comment on lines
-415
to
+424
| assert_eq!(actual_writeable.to_string(), $expected_str); | ||
| let ordering = $crate::Writeable::write_cmp_bytes(actual_writeable, $expected_str.as_bytes()); | ||
| assert_eq!(ordering, core::cmp::Ordering::Equal, $($arg)*); |
There was a problem hiding this comment.
I also added this to assert_writeable_parts_eq in #4787
|
I don't think we should add this. No-separator concatenation doesn't seem like the natural way to write out lists, there's list formatter for that. |
|
OK. Code backed up at main...sffc:omnicu:archive/impl-writeable-seq |
|
It occurred to me that we may be able to provide more useful impls for things such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this up but I'm not sure we need it. Seems useful though.