Putting DatagenProvider behind a feature
#4800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
sffc,
Manishearth and
a team
as code owners
sffc
requested changes
Apr 12, 2024
provider/datagen/src/transform/cldr/locale_canonicalizer/likely_subtags.rs
Outdated
Show resolved
Hide resolved
provider/datagen/src/transform/cldr/locale_canonicalizer/likely_subtags.rs
Show resolved
Hide resolved
| @@ -32,7 +32,7 @@ pub struct NoFallbackOptions {} | |||
| /// the locale fallback algorithm. If internal fallback is requested for an exporter that does | |||
| /// not support it, an error will occur. | |||
| #[non_exhaustive] | |||
| #[derive(Debug, Copy, Clone, PartialEq, Eq, serde::Deserialize, serde::Serialize, Hash)] | |||
| #[derive(Debug, Copy, Clone, PartialEq, Eq, Hash)] | |||
There was a problem hiding this comment.
Thought: I guess removing these impls is technically a breaking change. I might be okay with it though
There was a problem hiding this comment.
Yes this is breaking, this would be the only reason for the driver crate to need serde...
Merged
sffc
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4721