Update ICU tag to icu4x/2024-05-16/75.x #4913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsivonen
requested changes
May 17, 2024
There was a problem hiding this comment.
Thanks!
The changes made LGTM but seem insufficient. Specifically, the baked data in provider/baked/normalizer/data/macros/normalizer_uts46d_v1.rs.data should get the corresponding change.
The CI says: "Test data needs to be updated. Please run cargo make download-repo-sources, cargo make testdata and `cargo make testdata-hello-world:"
hsivonen
added a commit
to hsivonen/icu4x
that referenced
this pull request
May 22, 2024
sffc
pushed a commit
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates unicode-org/icu#3009