Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FFI tests #889

Merged
merged 6 commits into from Jul 22, 2021
Merged

Fix FFI tests #889

merged 6 commits into from Jul 22, 2021

Conversation

Manishearth
Copy link
Member

Turns out we weren't running them in a way that caused their failure to fail CI. oops.

@Manishearth Manishearth requested a review from a team as a code owner July 22, 2021 17:47
@Manishearth Manishearth requested a review from sffc July 22, 2021 17:47
@codecov-commenter
Copy link

Codecov Report

Merging #889 (b624649) into main (09d5aef) will increase coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #889      +/-   ##
==========================================
+ Coverage   74.32%   74.40%   +0.08%     
==========================================
  Files         206      206              
  Lines       13042    13092      +50     
==========================================
+ Hits         9693     9741      +48     
- Misses       3349     3351       +2     
Impacted Files Coverage Δ
ffi/capi/src/locale.rs 0.00% <0.00%> (ø)
provider/blob/src/export/blob_exporter.rs 94.44% <0.00%> (-2.78%) ⬇️
components/uniset/src/uniset.rs 98.93% <0.00%> (-1.07%) ⬇️
ffi/capi/src/provider.rs 0.00% <0.00%> (ø)
components/decimal/src/lib.rs 94.44% <0.00%> (ø)
components/plurals/src/lib.rs 86.95% <0.00%> (ø)
provider/blob/src/path_util.rs 100.00% <0.00%> (ø)
components/decimal/src/error.rs 0.00% <0.00%> (ø)
components/plurals/src/error.rs 33.33% <0.00%> (ø)
components/plurals/src/operands.rs 90.90% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09d5aef...b624649. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 22, 2021

Pull Request Test Coverage Report for Build 7950f4fa5948b81aa2fb11b3e0230e191c3465f6-PR-889

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 74.479%

Totals Coverage Status
Change from base Build 9acd1e99b12cc2c3eac2338fbe07f0059686b6e7: 0.008%
Covered Lines: 9873
Relevant Lines: 13256

💛 - Coveralls

@Manishearth
Copy link
Member Author

mac:

./../../include/locale.hpp:23:8: error: no template named 'optional' in namespace 'std'
  std::optional<std::string> ToString() const {
  ~~~~~^
./../../include/locale.hpp:30:12: error: no viable conversion from returned value of type 'std::string' (aka 'basic_string<char, char_traits<char>, allocator<char> >') to function return type 'int'
    return out;
           ^~~

windows:

gcc test.c ../../../../target/debug/libicu_capi.a -ldl -lpthread -lm -g
gcc.exe: error: ../../../../target/debug/libicu_capi.a: No such file or directory

Looks like our CAPI tests have been broken on other platforms for a while. I'm thinking of splitting our FFI tests onto a separate ubuntu-only builder for now

@Manishearth
Copy link
Member Author

Once this lands I can file followups to get it to build on Mac and Windows

dminor
dminor previously approved these changes Jul 22, 2021
ffi/capi/src/locale.rs Outdated Show resolved Hide resolved
@Manishearth Manishearth requested review from sffc and dminor July 22, 2021 18:28
@Manishearth Manishearth merged commit 83418f8 into unicode-org:main Jul 22, 2021
@Manishearth Manishearth deleted the ffitest-fix branch July 22, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants