Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'Data-driven tests' design document #807

Merged
merged 6 commits into from
Jun 17, 2024

Conversation

mradbourne
Copy link
Collaborator

This PR updates the testing design document to capture the decisions and conversation around testing since November.

The main updates are:

  • Update suggestions around test format to explain the rationale for JSON.
  • Describing the test schema.
  • Referencing test functions.
  • Removing example tests from the document because we have test files in the repo that illustrate usage.

Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; see inline comments.

exploration/data-driven-tests.md Outdated Show resolved Hide resolved
exploration/data-driven-tests.md Outdated Show resolved Hide resolved
exploration/data-driven-tests.md Outdated Show resolved Hide resolved
@aphillips aphillips added test-suite LDML46 Items that must be first for post-tech preview (LDML46) labels Jun 12, 2024
@aphillips aphillips merged commit 497a60a into unicode-org:main Jun 17, 2024
1 check passed
@mradbourne mradbourne deleted the update-data-driven-tests-doc branch June 18, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LDML46 Items that must be first for post-tech preview (LDML46) test-suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants