Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix charts & data for emoji 13.1 #25

Merged
merged 12 commits into from
Sep 17, 2020
Merged

Fix charts & data for emoji 13.1 #25

merged 12 commits into from
Sep 17, 2020

Conversation

macchiati
Copy link
Member

@macchiati macchiati commented Sep 12, 2020

Accumulated fixes for problems in the charts. Sorry that I didn't separate them into separate PRs.

Most of the changes are

  • updating the version to 13.1
  • updates to the internal data files to fix resulting generated files
  • retiring or working around some awful hacks to deal with the structure of the skintones with multiperson emoji
  • a couple of XUnicodeSet.java chunks of code used in testing.
  • some restructuring of code while debugging problems, with some tests for particular cases (just for debugging)
  • fixing some directories, since the structure changed when moving to github
  • a few updates to the header text for candidate charts
  • restucturing ProposalData.SINGLETON because of order-of-static-initialization problems.

@macchiati macchiati changed the title Fix charts for emoji Fix charts & data for emoji 13.1 Sep 12, 2020
@@ -62,6 +62,7 @@
/**
* Constants for versions
*/
public static final VersionInfo VERSION14 = VersionInfo.getInstance(13,1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this going to get fixed? (especially since VERSION_BETA below refers to it)

Copy link
Collaborator

@pedberg-icu pedberg-icu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emoji.java still seems to have

VersionInfo VERSION14 = VersionInfo.getInstance(13,1);

Otherwise seems OK

@macchiati
Copy link
Member Author

macchiati commented Sep 14, 2020 via email

@macchiati
Copy link
Member Author

Just fixed the version, and the proposal data.

@macchiati macchiati merged commit 40615fd into master Sep 17, 2020
@macchiati macchiati deleted the fix-charts-for-emoji branch October 22, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants