-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix charts & data for emoji 13.1 #25
Conversation
…shakes with tones. Note special code to hack the names.
…. Unrelated utility
…; also two unrelated changes to remove errors in UnicodeJsps.
@@ -62,6 +62,7 @@ | |||
/** | |||
* Constants for versions | |||
*/ | |||
public static final VersionInfo VERSION14 = VersionInfo.getInstance(13,1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this going to get fixed? (especially since VERSION_BETA below refers to it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emoji.java still seems to have
VersionInfo VERSION14 = VersionInfo.getInstance(13,1);
Otherwise seems OK
Will fix, thanks
…On Sun, Sep 13, 2020, 21:06 Peter Edberg ***@***.***> wrote:
***@***.**** commented on this pull request.
Emoji.java still seems to have
VersionInfo VERSION14 = VersionInfo.getInstance(13,1);
Otherwise seems OK
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#25 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMCWGR2TJDUJNSIYQSLSFWJDTANCNFSM4RKB3IQQ>
.
|
Just fixed the version, and the proposal data. |
Accumulated fixes for problems in the charts. Sorry that I didn't separate them into separate PRs.
Most of the changes are