Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2 errors in Confusables exposed by change in protectCollections #35

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Fix 2 errors in Confusables exposed by change in protectCollections #35

merged 1 commit into from
Jan 11, 2021

Conversation

macchiati
Copy link
Member

This might help

Manishearth
Manishearth approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, thanks! It's able to do a partial run now, there are further errors, but I can debug them myself. What I mostly needed to know was whether my setup was broken or whether these things were actually bugs.

@macchiati macchiati merged commit efe9fb5 into unicode-org:master Jan 11, 2021
@macchiati macchiati deleted the Clean-up-bug-in-Confusables branch January 11, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@macchiati @Manishearth