Final tweaks to MSVC build #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merged, thanks! @stephengroat, can we run "msbuild" in Appveyor, and even better, keep its artifacts? |
|
@aquynh looks likes it's already being run do you know what artifacts you want to keep? i'm currently keeping unicorn.dll https://github.com/unicorn-engine/unicorn/blob/master/.appveyor.yml#L65 |
|
so this unicorn.dll already natively built with msvc. the goal is that users can download & use the artifacts to build their own tools on Windows (without having to build latest unicorn themselves). do we already provide the link to the artifacts in our docs yet? |
|
pr specific or based off of last successful master build? is a permalink to the unicorn dll for the last successful job on master for msvc |
chfl4gs
pushed a commit
to chfl4gs/unicorn
that referenced
this pull request
Apr 7, 2020
* Quote paths in msvc postbuildevent scripts * Update MSVC readme with some new advice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this we can release 1.0.2.