cmake: fix build if workdir is outside of CMAKE_BINARY_DIR #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Johnnynator |
|
Mh... I did try, maybe smth of a different build leaked in. But in that case it should be needed for both. |
this e.g. happens if you would try to compile this like this: cmake -B build cmake --build build --config Release
|
This doesn't make any sense why the previous change did work for me. The create_config script is totally workdir independent and just takes stdin/stdout, cmake itself already works with the correct paths. |
scribam
approved these changes
Jun 5, 2020
|
merged, thanks! |
aquynh
pushed a commit
that referenced
this pull request
Jun 6, 2020
this e.g. happens if you would try to compile this like this: cmake -B build cmake --build build --config Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this e.g. happens if you would try to compile this like this:
cmake -B build
cmake --build build --config Release
@scribam Should fix the remaining CI failures of Vita3K/Vita3K#727