Refactor CMake #1544
Merged
Refactor CMake #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrexodia
force-pushed
the
cmake-subdirectory
branch
5 times, most recently
from
f9469a0
to
416d623
Compare
|
Strange, I remember I cherry-picked it. |
mrexodia
force-pushed
the
cmake-subdirectory
branch
from
416d623
to
19c8f71
Compare
wtdcode
reviewed
Jan 18, 2022
Everything from unicorn-engine#1373 seems to have been undone, so I did it again.
mrexodia
force-pushed
the
cmake-subdirectory
branch
from
19c8f71
to
c0e86b0
Compare
|
I think I also fixed the rust build. |
wtdcode
reviewed
Jan 18, 2022
wtdcode
reviewed
Jan 18, 2022
wtdcode
reviewed
Jan 18, 2022
wtdcode
reviewed
Jan 18, 2022
mrexodia
force-pushed
the
cmake-subdirectory
branch
from
26938ec
to
5d471d8
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything from #1373 seems to have been undone, so I did it again