Fix sample_ctl.py #1830
Merged
Fix sample_ctl.py #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your interest! Note the patch should go to dev branch. |
|
@wtdcode fixed now. |
- Match the types of UC_HOOK_CODE_CB and UC_HOOK_INSN_SYS_CB to C - Avoid building a new namedtuple class in every call to _hook_insn_sys_cb
wtdcode
reviewed
May 10, 2023
bindings/python/unicorn/unicorn.py
Outdated
| @@ -424,6 +424,9 @@ class uc_arm64_cp_reg(ctypes.Structure): | |||
| ("val", ctypes.c_uint64) | |||
| ] | |||
|
|
|||
| def __repr__(self): | |||
There was a problem hiding this comment.
If you would like to add __repr__ for uc_arm64_cp_reg, could you do the same for uc_arm_cp_reg?
|
@wtdcode ok, I just added |
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sample_ctl.pywas not running correctly. It was crashing with various errors:TypeError: Uc.ctl_remove_cache() missing 1 required positional argument: 'end',KeyError: 64. This patch fixes the relevant errors in the bindings and scripts.