Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit uc_mem_(read|write) size to INT_MAX #219

Closed

Conversation

JonathonReinhart
Copy link
Member

Fixes #132.

@aquynh
Copy link
Member

aquynh commented Oct 29, 2015

if we limit the read/write size to INT_MAX, should we also limit the memory size of uc_mem_map() & uc_mem_unmap() to the same number?

@JonathonReinhart
Copy link
Member Author

This was added simply because cpu_physical_memory_rw takes an int. I would have to review the underlying code used to implement uc_mem_map. But nothing is stopping one from calling read multiple times to overcome the 4GB limitation, if they have more memory mapped.

@wtdcode
Copy link
Member

wtdcode commented Oct 3, 2021

Link to #1217 for further investigation.

wtdcode added a commit that referenced this pull request Oct 3, 2021
@wtdcode
Copy link
Member

wtdcode commented Oct 3, 2021

Fixed in df5daed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

size_t size in uc_mem_read
3 participants