Creator tablecell div image support #179
Conversation
| } | ||
| return p.getTextWidth() / 1000.0 | ||
| } | ||
|
|
||
| // Height returns the height of the Paragraph. The height is calculated based on the input text and how it is wrapped |
There was a problem hiding this comment.
Should end with period as godoc style.
There was a problem hiding this comment.
Actually it does end with a period (sentence is continued in following line), see
unidoc/pdf/creator/paragraph.go
Line 201 in d5fc69b
pdf/creator/table.go
Outdated
| @@ -208,7 +210,50 @@ func (table *Table) GeneratePageBlocks(ctx DrawContext) ([]*Block, DrawContext, | |||
| // Add diff to last row | |||
There was a problem hiding this comment.
Should end with period as godoc style.
There was a problem hiding this comment.
not so important within function (does not go into godoc), but sure will fix as this is a sentence and is more consistent.
pdf/creator/table.go
Outdated
| newh := img.Height() + img.margins.top + img.margins.bottom | ||
| if newh > h { | ||
| diffh := newh - h | ||
| // Add diff to last row |
There was a problem hiding this comment.
Should end with period as godoc style.
pdf/creator/table.go
Outdated
| newh := ctx.Height - h | ||
| if newh > h { | ||
| diffh := newh - h | ||
| // Add diff to last row |
There was a problem hiding this comment.
Should end with period as godoc style.
pdf/creator/table.go
Outdated
| // Relative mode. | ||
| // Move back X after. | ||
| ctx.X = origCtx.X | ||
| // Return original width |
There was a problem hiding this comment.
Should end with period as godoc style.
pdf/creator/table.go
Outdated
| ctx.X = origCtx.X | ||
| // Return original width | ||
| ctx.Width = origCtx.Width | ||
| // Add the bottom margin |
There was a problem hiding this comment.
Should end with period as godoc style.
pdf/creator/table_test.go
Outdated
|
|
||
| pageHistoryTable.SkipCells(1) | ||
|
|
||
| // Add image |
There was a problem hiding this comment.
Should end with period as godoc style.
pdf/creator/table_test.go
Outdated
|
|
||
| pageHistoryTable.SkipCells(1) | ||
|
|
||
| // Add image |
There was a problem hiding this comment.
Should end with period as godoc style.
New Division container component for containing multiple Drawables and can wrap across pages (unlike Block). Can be used in table cells to contain multiple paragraphs with different styles.
Support added for Division and Image in table cell.