Multi-style paragraphs #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunnsth
requested changes
Sep 25, 2018
pdf/creator/styled_paragraph.go
Outdated
| lines [][]TextChunk | ||
| } | ||
|
|
||
| // NewStyledParagraph create a new styled paragraph. |
pdf/creator/text_style.go
Outdated
| FontSize float64 | ||
| } | ||
|
|
||
| // NewTextStyle create a new text style object which can be used with chunks |
pdf/creator/text_style.go
Outdated
| } | ||
| } | ||
|
|
||
| // TextChunk represents a chunk a text along with a particular style. |
There was a problem hiding this comment.
should be "a chunk of text" ?
|
Corrected the comment typos |
gunnsth
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for multiple styles inside paragraphs by introducing the StyledParagraph component.
This PR is should resolve #200