Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table of Contents Links #314

Merged
merged 5 commits into from
Jan 11, 2019
Merged

Table of Contents Links #314

merged 5 commits into from
Jan 11, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Jan 11, 2019

This PR adds link annotation support for the TOC component.
Links are created automatically for the Chapter and Subchapter components.

Resolves #264

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #314 into v3 will increase coverage by 0.1%.
The diff coverage is 86.84%.

Impacted file tree graph

@@           Coverage Diff            @@
##               v3    #314     +/-   ##
========================================
+ Coverage   38.49%   38.6%   +0.1%     
========================================
  Files         120     120             
  Lines       22886   22941     +55     
========================================
+ Hits         8811    8856     +45     
- Misses      12800   12806      +6     
- Partials     1275    1279      +4
Impacted Files Coverage Δ
pdf/creator/subchapter.go 68.67% <100%> (+2%) ⬆️
pdf/creator/chapters.go 61.72% <100%> (+2.51%) ⬆️
pdf/creator/toc_line.go 73.8% <100%> (+3.8%) ⬆️
pdf/creator/styled_paragraph.go 86.18% <100%> (+0.1%) ⬆️
pdf/creator/creator.go 67.85% <100%> (+0.31%) ⬆️
pdf/creator/toc.go 85.32% <42.85%> (-2.92%) ⬇️
pdf/creator/block.go 67.61% <50%> (-0.57%) ⬇️
pdf/creator/text_chunk.go 89.47% <77.77%> (-3.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe3a3e...37a710f. Read the comment docs.

Copy link

@gunnsth-review gunnsth-review left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@gunnsth gunnsth merged commit 82906a2 into unidoc:v3 Jan 11, 2019
@adrg adrg deleted the toc-links branch January 14, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants