Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PNG predictor issues. Fixes #313. #320

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Fix for PNG predictor issues. Fixes #313. #320

merged 2 commits into from
Jan 22, 2019

Conversation

gunnsth
Copy link
Contributor

@gunnsth gunnsth commented Jan 16, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #320 into v3 will increase coverage by 0.11%.
The diff coverage is 89.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #320      +/-   ##
==========================================
+ Coverage   38.56%   38.68%   +0.11%     
==========================================
  Files         121      122       +1     
  Lines       23079    23083       +4     
==========================================
+ Hits         8901     8930      +29     
+ Misses      12897    12872      -25     
  Partials     1281     1281
Impacted Files Coverage Δ
pdf/core/encoding.go 38.56% <87.87%> (+1.89%) ⬆️
pdf/core/paeth.go 93.33% <93.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d17ce...3bd2564. Read the comment docs.

Copy link
Collaborator

@peterwilliams97 peterwilliams97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.
The code works with some tests from a command line example program. I will convert these tests to a go test and make a PR after this branch is merged.

Copy link
Collaborator

@peterwilliams97 peterwilliams97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.
The code works with some tests from a command line example program. I will add these tests to your go test file and make a PR after this branch is merged.

@gunnsth gunnsth merged commit caca4b4 into v3 Jan 22, 2019
@gunnsth gunnsth deleted the v3-predictor-fixes branch January 22, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants