Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression issues #331

Merged
merged 11 commits into from
Jan 25, 2019
Merged

Compression issues #331

merged 11 commits into from
Jan 25, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Jan 25, 2019

Fixes various scenarios in which the optimizer freezes or distorts the original PDF images.

Resolves #322


This change is Reviewable

Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

Merging #331 into v3 will decrease coverage by 0.14%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #331      +/-   ##
==========================================
- Coverage   38.68%   38.54%   -0.15%     
==========================================
  Files         122      122              
  Lines       23083    23167      +84     
==========================================
  Hits         8930     8930              
- Misses      12872    12956      +84     
  Partials     1281     1281
Impacted Files Coverage Δ
pdf/model/xobject.go 0% <0%> (ø) ⬆️
pdf/model/image.go 12.92% <0%> (-1.05%) ⬇️
pdf/model/optimize/image_ppi.go 0% <0%> (ø) ⬆️
pdf/core/encoding.go 36.43% <0%> (-2.14%) ⬇️
pdf/model/colorspace.go 6.3% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa5feef...d6a5277. Read the comment docs.

@gunnsth gunnsth merged commit 1dd3de8 into unidoc:v3 Jan 25, 2019
@gunnsth gunnsth mentioned this pull request Jan 25, 2019
@adrg adrg deleted the compression-issues branch January 27, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants