Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.imagemark #335

Merged
merged 2 commits into from
Jan 31, 2019
Merged

V3.imagemark #335

merged 2 commits into from
Jan 31, 2019

Conversation

peterwilliams97
Copy link
Collaborator

Fix and test for ICC color spaces without default ranges.
I found this bug while testing the new image position code and added a test function to regression test it.

@codecov
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #335 into v3 will increase coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##               v3    #335      +/-   ##
=========================================
+ Coverage   51.76%   52.1%   +0.34%     
=========================================
  Files         145     145              
  Lines       25207   25212       +5     
=========================================
+ Hits        13048   13137      +89     
+ Misses      10396   10297      -99     
- Partials     1763    1778      +15
Impacted Files Coverage Δ
pdf/extractor/image.go 58.71% <ø> (ø) ⬆️
pdf/model/colorspace.go 30.42% <100%> (+3.62%) ⬆️
pdf/contentstream/processor.go 49.08% <0%> (+0.6%) ⬆️
pdf/model/xobject.go 34.69% <0%> (+0.87%) ⬆️
pdf/model/functions.go 39.86% <0%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3121645...f3f03ef. Read the comment docs.

@gunnsth gunnsth merged commit 2cc717d into unidoc:v3 Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants