Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character spacing #338

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Character spacing #338

merged 2 commits into from
Feb 7, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Feb 6, 2019

Add TextStyle character spacing field.
Integrate character spacing into the StyledParagraph component.

Resolves #119

@codecov
Copy link

codecov bot commented Feb 6, 2019

Codecov Report

Merging #338 into v3 will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #338      +/-   ##
==========================================
+ Coverage   58.19%   58.22%   +0.03%     
==========================================
  Files         145      145              
  Lines       25217    25231      +14     
==========================================
+ Hits        14674    14692      +18     
+ Misses      10176    10170       -6     
- Partials      367      369       +2
Impacted Files Coverage Δ
pdf/creator/text_style.go 100% <ø> (ø) ⬆️
pdf/creator/styled_paragraph.go 92.27% <100%> (-0.23%) ⬇️
pdf/model/image.go 57.82% <0%> (-1.37%) ⬇️
pdf/model/optimize/image.go 78.04% <0%> (-1.22%) ⬇️
pdf/creator/image.go 83.33% <0%> (-0.65%) ⬇️
pdf/core/primitives.go 77.65% <0%> (-0.64%) ⬇️
pdf/creator/invoice.go 89.58% <0%> (-0.49%) ⬇️
pdf/model/functions.go 49.11% <0%> (-0.45%) ⬇️
pdf/extractor/text.go 68.06% <0%> (-0.44%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 601dc4a...4641133. Read the comment docs.

Copy link

@gunnsth-review gunnsth-review left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@gunnsth gunnsth merged commit 1d6f996 into unidoc:v3 Feb 7, 2019
@adrg adrg deleted the character-spacing branch February 7, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants