Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dot imports #341

Merged
merged 13 commits into from
Feb 9, 2019
Merged

Remove dot imports #341

merged 13 commits into from
Feb 9, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Feb 9, 2019

Removes dot imports from the model package. (I did not find any others using them)
Resolves #309

@codecov
Copy link

codecov bot commented Feb 9, 2019

Codecov Report

Merging #341 into v3 will increase coverage by 0.02%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #341      +/-   ##
==========================================
+ Coverage   58.22%   58.25%   +0.02%     
==========================================
  Files         145      145              
  Lines       25231    25235       +4     
==========================================
+ Hits        14691    14700       +9     
  Misses      10170    10170              
+ Partials      370      365       -5
Impacted Files Coverage Δ
pdf/model/pattern.go 0% <0%> (ø) ⬆️
pdf/model/shading.go 0% <0%> (ø) ⬆️
pdf/model/image.go 58.5% <100%> (-0.69%) ⬇️
pdf/model/structures.go 80% <100%> (+1.42%) ⬆️
pdf/model/resources.go 57.2% <56.36%> (+0.43%) ⬆️
pdf/model/page.go 56.81% <57.3%> (ø) ⬆️
pdf/model/xobject.go 51.6% <58.69%> (+1.16%) ⬆️
pdf/model/functions.go 48.89% <65.9%> (-0.67%) ⬇️
pdf/model/outlines.go 67.36% <80%> (ø) ⬆️
pdf/model/reader.go 66.44% <86.84%> (ø) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8f1b9...f9989f2. Read the comment docs.

@gunnsth gunnsth merged commit 8d1cf1a into unidoc:v3 Feb 9, 2019
@adrg adrg deleted the remove-dot-imports branch February 19, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants