Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature support refactoring #343

Merged
merged 3 commits into from
Feb 12, 2019
Merged

Signature support refactoring #343

merged 3 commits into from
Feb 12, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Feb 12, 2019 •
edited

Resolves #342

@adrg adrg changed the title Signature support Signature support refactoring Feb 12, 2019
@codecov
Copy link

codecov bot commented Feb 12, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (v3-a5i-pdf-sign@e7f5b37). Click here to learn what that means.
The diff coverage is 54.76%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             v3-a5i-pdf-sign     #343   +/-   ##
==================================================
  Coverage                   ?   52.82%           
==================================================
  Files                      ?      149           
  Lines                      ?    25716           
  Branches                   ?        0           
==================================================
  Hits                       ?    13584           
  Misses                     ?    10313           
  Partials                   ?     1819
Impacted Files Coverage Δ
pdf/model/sighandler/sighandler_rsa_sha1.go 5.4% <ø> (ø)
pdf/model/writer.go 77.7% <100%> (ø)
pdf/model/appearance.go 100% <100%> (ø)
pdf/model/signature.go 54.24% <30.95%> (ø)
pdf/model/fields.go 47.49% <63.63%> (ø)
pdf/model/sighandler/sighandler_pkcs7.go 55% <75%> (ø)
pdf/model/appender.go 77.8% <80%> (ø)
pdf/model/signature_handler.go 55.04% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7f5b37...cda8553. Read the comment docs.

gunnsth
gunnsth approved these changes Feb 12, 2019
View reviewed changes
pdf/model/appearance.go
// PdfAppearance contains the common attributes of an appearance form field.
type PdfAppearance struct {
// PdfSignatureAppearance contains the common attributes of an appearance form field.
type PdfSignatureAppearance struct {
*PdfField
*PdfAnnotationWidget
// TODO(gunnsth): Signature is not really part of an appearance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove the TODO

@gunnsth gunnsth merged commit 4d25f7f into unidoc:v3-a5i-pdf-sign Feb 12, 2019
@adrg adrg deleted the signature-support branch February 19, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnsth gunnsth gunnsth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@adrg @gunnsth