Reduce memory thrashing when optimising large PDFs #347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change
optimize.(*CombineDuplicateDirectObjects).Optimize
has spent 97% of it's runtime ingithub.com/unidoc/unidoc/pdf/core.(*PdfObjectDictionary).WriteString
and optimising a 500 page PDF with 4 images / page took a couple minutes on 8-thread cpuAfter the change it's <1% and optimising the same file takes seconds.