Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital signatures refactoring #350

Merged
merged 2 commits into from
Feb 18, 2019
Merged

Digital signatures refactoring #350

merged 2 commits into from
Feb 18, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Feb 18, 2019

Improve PDF sign method signature.

@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #350 into v3-a5i-pdf-sign will increase coverage by 0.1%.
The diff coverage is 90.19%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           v3-a5i-pdf-sign     #350     +/-   ##
==================================================
+ Coverage            58.44%   58.55%   +0.1%     
==================================================
  Files                  149      148      -1     
  Lines                25716    25658     -58     
==================================================
- Hits                 15031    15024      -7     
+ Misses               10313    10265     -48     
+ Partials               372      369      -3
Impacted Files Coverage Δ
pdf/model/fields.go 54.94% <100%> (+1.54%) ⬆️
pdf/model/appender.go 83.12% <78.94%> (-0.29%) ⬇️
pdf/model/signature.go 83.33% <95%> (+26.47%) ⬆️
pdf/internal/sampling/resample.go 94.11% <0%> (-0.85%) ⬇️
pdf/model/functions.go 48.89% <0%> (-0.23%) ⬇️
pdf/model/colorspace.go 37.65% <0%> (ø) ⬆️
pdf/model/annotations.go 23.17% <0%> (+0.08%) ⬆️
pdf/core/primitives.go 78.6% <0%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef5b5a...28ad01f. Read the comment docs.

Copy link

@gunnsth-review gunnsth-review left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@gunnsth gunnsth merged commit 473eb5f into unidoc:v3-a5i-pdf-sign Feb 18, 2019
@sayhei
Copy link

sayhei commented Apr 4, 2019

can have an example of how to use digital sign?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants