Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor code documentation improvements #352

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Minor code documentation improvements #352

merged 1 commit into from
Feb 19, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Feb 19, 2019

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #352 into v3-a5i-pdf-sign will decrease coverage by 5.37%.
The diff coverage is 50%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           v3-a5i-pdf-sign     #352      +/-   ##
===================================================
- Coverage            60.19%   54.82%   -5.38%     
===================================================
  Files                  152      152              
  Lines                27222    27161      -61     
===================================================
- Hits                 16386    14890    -1496     
+ Misses               10447    10432      -15     
- Partials               389     1839    +1450
Impacted Files Coverage Δ
pdf/model/sighandler/sighandler_rsa_sha1.go 5.4% <ø> (-1.36%) ⬇️
pdf/model/signature.go 77.86% <0%> (+18.42%) ⬆️
pdf/model/appender.go 76.48% <75%> (-12.71%) ⬇️
pdf/creator/utils.go 55.55% <0%> (-22.23%) ⬇️
pdf/core/security/handlers.go 33.33% <0%> (-16.67%) ⬇️
pdf/model/optimize/image_ppi.go 56.71% <0%> (-16.42%) ⬇️
pdf/model/reader.go 50.5% <0%> (-15.94%) ⬇️
pdf/ps/exec.go 62.96% <0%> (-14.82%) ⬇️
pdf/ps/operations.go 53.45% <0%> (-13.84%) ⬇️
pdf/model/signature_handler.go 55.04% <0%> (-13.77%) ⬇️
... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e93ffb2...38d71b4. Read the comment docs.

@gunnsth gunnsth merged commit 0fa9092 into unidoc:v3-a5i-pdf-sign Feb 19, 2019
@adrg adrg deleted the v3-a5i-pdf-sign branch February 19, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants