-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signature appearance #354
Signature appearance #354
Conversation
Codecov Report
@@ Coverage Diff @@
## v3 #354 +/- ##
==========================================
+ Coverage 54.82% 55.21% +0.39%
==========================================
Files 152 152
Lines 27161 27294 +133
==========================================
+ Hits 14890 15070 +180
+ Misses 10432 10371 -61
- Partials 1839 1853 +14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
Add text based signature appearance.
Addresses #340 and #323 (except for the signature appearance image support which will be addressed in another PR)