Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature appearance #354

Merged
merged 10 commits into from
Feb 21, 2019
Merged

Signature appearance #354

merged 10 commits into from
Feb 21, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Feb 21, 2019

Add text based signature appearance.
Addresses #340 and #323 (except for the signature appearance image support which will be addressed in another PR)

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #354 into v3 will increase coverage by 0.39%.
The diff coverage is 79.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #354      +/-   ##
==========================================
+ Coverage   54.82%   55.21%   +0.39%     
==========================================
  Files         152      152              
  Lines       27161    27294     +133     
==========================================
+ Hits        14890    15070     +180     
+ Misses      10432    10371      -61     
- Partials     1839     1853      +14
Impacted Files Coverage Δ
pdf/model/fields.go 49.71% <100%> (+0.87%) ⬆️
pdf/model/appender.go 76.13% <60%> (-0.36%) ⬇️
pdf/annotator/field_appearance.go 10.87% <77.27%> (+10.87%) ⬆️
pdf/annotator/form_field.go 13.57% <82.6%> (+13.57%) ⬆️
pdf/core/primitives.go 75.26% <0%> (-0.64%) ⬇️
pdf/model/colorspace.go 32.86% <0%> (+0.13%) ⬆️
pdf/contentstream/creator.go 46.48% <0%> (+8.71%) ⬆️
pdf/model/xobject.go 58.01% <0%> (+11.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b70ef...2b1c5e7. Read the comment docs.

Copy link

@gunnsth-review gunnsth-review left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@gunnsth gunnsth merged commit 0fcf981 into unidoc:v3 Feb 21, 2019
@adrg adrg deleted the signature-appearance branch April 10, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants