Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature refactoring #358

Merged
merged 2 commits into from
Feb 27, 2019
Merged

Signature refactoring #358

merged 2 commits into from
Feb 27, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Feb 27, 2019

  • Remove duplicate code in Signature model ToPdfObject
  • Update signature object ByteRange field in the appender write method

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #358 into v3 will decrease coverage by 5.39%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##               v3    #358     +/-   ##
========================================
- Coverage   60.59%   55.2%   -5.4%     
========================================
  Files         152     152             
  Lines       27304   27301      -3     
========================================
- Hits        16546   15072   -1474     
- Misses      10364   10375     +11     
- Partials      394    1854   +1460
Impacted Files Coverage Δ
pdf/model/signature.go 77.5% <100%> (-4.47%) ⬇️
pdf/model/appender.go 75.99% <100%> (-6.89%) ⬇️
pdf/creator/utils.go 55.55% <0%> (-22.23%) ⬇️
pdf/core/security/handlers.go 33.33% <0%> (-16.67%) ⬇️
pdf/model/optimize/image_ppi.go 56.71% <0%> (-16.42%) ⬇️
pdf/model/reader.go 50.5% <0%> (-15.94%) ⬇️
pdf/ps/exec.go 62.96% <0%> (-14.82%) ⬇️
pdf/ps/operations.go 53.45% <0%> (-13.84%) ⬇️
pdf/model/signature_handler.go 55.04% <0%> (-13.77%) ⬇️
pdf/extractor/image.go 66.97% <0%> (-13.77%) ⬇️
... and 96 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40123ce...e21121d. Read the comment docs.

@gunnsth gunnsth merged commit 4bb53f7 into unidoc:v3 Feb 27, 2019
@adrg adrg deleted the signature-improve branch March 6, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants