-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image extraction options #363
Conversation
Codecov Report
@@ Coverage Diff @@
## v3 #363 +/- ##
=========================================
+ Coverage 55.22% 60.6% +5.37%
=========================================
Files 151 151
Lines 27218 27224 +6
=========================================
+ Hits 15031 16498 +1467
+ Misses 10341 10339 -2
+ Partials 1846 387 -1459
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one minor change needed.
pdf/extractor/image.go
Outdated
@@ -12,10 +12,21 @@ import ( | |||
"github.com/unidoc/unidoc/pdf/model" | |||
) | |||
|
|||
// ImageExtractOpts contains options for controlling image extraction from | |||
// PDF pages. | |||
type ImageExtractOpts struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use "Options" rather than "Opts" for consistency (Options used in elsewhere in unidoc).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Resolves #362