Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WriteString method benchmarks for primitive objects #366

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Add WriteString method benchmarks for primitive objects #366

merged 1 commit into from
Mar 11, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Mar 11, 2019

No description provided.

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #366 into v3 will decrease coverage by 5.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #366      +/-   ##
==========================================
- Coverage   61.21%   55.23%   -5.99%     
==========================================
  Files         151      151              
  Lines       27251    27222      -29     
==========================================
- Hits        16682    15035    -1647     
- Misses      10107    10339     +232     
- Partials      462     1848    +1386
Impacted Files Coverage Δ
pdf/creator/utils.go 55.55% <0%> (-22.23%) ⬇️
pdf/core/security/handlers.go 33.33% <0%> (-16.67%) ⬇️
pdf/model/optimize/image_ppi.go 56.71% <0%> (-16.42%) ⬇️
pdf/model/reader.go 50.5% <0%> (-15.94%) ⬇️
pdf/core/parser.go 66.53% <0%> (-15.12%) ⬇️
pdf/ps/exec.go 62.96% <0%> (-14.82%) ⬇️
pdf/core/encoding.go 44.28% <0%> (-13.98%) ⬇️
pdf/ps/operations.go 53.45% <0%> (-13.84%) ⬇️
pdf/model/signature_handler.go 55.04% <0%> (-13.77%) ⬇️
pdf/core/stream.go 31.08% <0%> (-13.52%) ⬇️
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2749e11...e8dca58. Read the comment docs.

@gunnsth gunnsth merged commit e1ff845 into unidoc:v3 Mar 11, 2019
@adrg adrg deleted the primitives-benchmark branch March 11, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants