Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing compatibility fixes [v3] #392

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Conversation

gunnsth
Copy link
Contributor

@gunnsth gunnsth commented Mar 31, 2019

Addresses 2 errors encountered in corpus PDF files.

@codecov
Copy link

codecov bot commented Mar 31, 2019

Codecov Report

Merging #392 into v3 will decrease coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #392      +/-   ##
==========================================
- Coverage   55.38%   55.37%   -0.01%     
==========================================
  Files         151      151              
  Lines       27433    27435       +2     
==========================================
  Hits        15193    15193              
- Misses      10378    10380       +2     
  Partials     1862     1862
Impacted Files Coverage Δ
pdf/core/parser.go 66.7% <25%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54264e3...5b419ad. Read the comment docs.

@gunnsth gunnsth requested a review from adrg April 1, 2019 23:49
@gunnsth gunnsth added this to the v3.0.0-rc.1 milestone Apr 2, 2019
Copy link
Collaborator

@adrg adrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gunnsth gunnsth merged commit de4fb06 into v3 Apr 2, 2019
@gunnsth gunnsth deleted the v3-parsing-compatibility-fixes branch April 2, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants