Image loading performance enhancements [v3] #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid redrawing RGBA images again if loaded.
Change EncodeBytes for CCITTFaxDecode to assume data with 1 color component rather than 3.
CCITT rendering has changed slightly (visual comparison looks good).
Codecov Report
@@ Coverage Diff @@
## v3 #394 +/- ##
==========================================
- Coverage 61.28% 61.24% -0.04%
==========================================
Files 153 153
Lines 27631 27646 +15
==========================================
- Hits 16934 16933 -1
- Misses 10304 10319 +15
- Partials 393 394 +1
Continue to review full report at Codecov.
|
adrg
approved these changes
Apr 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #393 at least partly. The performance is still expected to be poor for colored JPG images, as those images still are converted to RGBA.