Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No break space character metrics #397

Merged
merged 3 commits into from
Apr 2, 2019
Merged

No break space character metrics #397

merged 3 commits into from
Apr 2, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Apr 2, 2019

Use regular space character metrics for the no-break space character if nbsp handling is not already defined.
Addresses #396

@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #397 into v3 will increase coverage by 5.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #397      +/-   ##
==========================================
+ Coverage   55.37%   60.56%   +5.19%     
==========================================
  Files         151      151              
  Lines       27435    27438       +3     
==========================================
+ Hits        15193    16619    +1426     
+ Misses      10380    10355      -25     
+ Partials     1862      464    -1398
Impacted Files Coverage Δ
pdf/model/internal/fonts/std.go 73.8% <100%> (+4.57%) ⬆️
pdf/annotator/field_appearance.go 11.5% <0%> (+0.62%) ⬆️
pdf/creator/division.go 89.13% <0%> (+1.08%) ⬆️
pdf/model/outline.go 86.74% <0%> (+1.2%) ⬆️
pdf/creator/invoice.go 90.07% <0%> (+1.21%) ⬆️
pdf/model/sighandler/sighandler_rsa_sha1.go 6.75% <0%> (+1.35%) ⬆️
pdf/annotator/form_field.go 14.78% <0%> (+1.4%) ⬆️
pdf/creator/toc_line.go 75.39% <0%> (+1.58%) ⬆️
pdf/model/annotations.go 23.28% <0%> (+1.65%) ⬆️
pdf/internal/ccittfax/decode.go 94.98% <0%> (+1.75%) ⬆️
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de4fb06...e97d294. Read the comment docs.

@gunnsth gunnsth merged commit d21dab0 into unidoc:v3 Apr 2, 2019
@adrg adrg deleted the no-break-spaces branch April 4, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants