Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rows and Cols methods to the Table component #402

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Add Rows and Cols methods to the Table component #402

merged 2 commits into from
Apr 4, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Apr 4, 2019

Addresses #401

@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #402 into v3 will decrease coverage by 5.44%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #402      +/-   ##
==========================================
- Coverage   60.87%   55.43%   -5.45%     
==========================================
  Files         151      151              
  Lines       27491    27468      -23     
==========================================
- Hits        16736    15226    -1510     
- Misses      10365    10380      +15     
- Partials      390     1862    +1472
Impacted Files Coverage Δ
pdf/creator/table.go 86.8% <100%> (-5.29%) ⬇️
pdf/creator/utils.go 55.55% <0%> (-22.23%) ⬇️
pdf/core/security/handlers.go 33.33% <0%> (-16.67%) ⬇️
pdf/model/optimize/image_ppi.go 59.7% <0%> (-16.42%) ⬇️
pdf/model/reader.go 48.34% <0%> (-15.17%) ⬇️
pdf/ps/exec.go 62.96% <0%> (-14.82%) ⬇️
pdf/ps/operations.go 53.45% <0%> (-13.84%) ⬇️
pdf/model/signature_handler.go 55.04% <0%> (-13.77%) ⬇️
pdf/core/stream.go 31.08% <0%> (-13.52%) ⬇️
pdf/extractor/image.go 66.08% <0%> (-13.05%) ⬇️
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3712670...4ee3858. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #402 into v3 will decrease coverage by 5.44%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #402      +/-   ##
==========================================
- Coverage   60.87%   55.43%   -5.45%     
==========================================
  Files         151      151              
  Lines       27491    27468      -23     
==========================================
- Hits        16736    15226    -1510     
- Misses      10365    10380      +15     
- Partials      390     1862    +1472
Impacted Files Coverage Δ
pdf/creator/table.go 86.8% <100%> (-5.29%) ⬇️
pdf/creator/utils.go 55.55% <0%> (-22.23%) ⬇️
pdf/core/security/handlers.go 33.33% <0%> (-16.67%) ⬇️
pdf/model/optimize/image_ppi.go 59.7% <0%> (-16.42%) ⬇️
pdf/model/reader.go 48.34% <0%> (-15.17%) ⬇️
pdf/ps/exec.go 62.96% <0%> (-14.82%) ⬇️
pdf/ps/operations.go 53.45% <0%> (-13.84%) ⬇️
pdf/model/signature_handler.go 55.04% <0%> (-13.77%) ⬇️
pdf/core/stream.go 31.08% <0%> (-13.52%) ⬇️
pdf/extractor/image.go 66.08% <0%> (-13.05%) ⬇️
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3712670...4ee3858. Read the comment docs.

@gunnsth gunnsth merged commit 82a1d32 into unidoc:v3 Apr 4, 2019
@adrg adrg deleted the table-rows-cols branch April 4, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants