Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtable row height #404

Merged
merged 3 commits into from
Apr 9, 2019
Merged

Subtable row height #404

merged 3 commits into from
Apr 9, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Apr 8, 2019

  • Copy row height when adding subtables
  • Add GetRowHeight method to the Table component

Addresses #403

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #404 into v3 will decrease coverage by 5.39%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##               v3     #404     +/-   ##
=========================================
- Coverage   60.84%   55.45%   -5.4%     
=========================================
  Files         151      151             
  Lines       27471    27477      +6     
=========================================
- Hits        16716    15236   -1480     
- Misses      10371    10377      +6     
- Partials      384     1864   +1480
Impacted Files Coverage Δ
pdf/creator/table.go 87.3% <83.33%> (-4.43%) ⬇️
pdf/creator/utils.go 55.55% <0%> (-22.23%) ⬇️
pdf/core/security/handlers.go 33.33% <0%> (-16.67%) ⬇️
pdf/model/optimize/image_ppi.go 59.7% <0%> (-16.42%) ⬇️
pdf/model/reader.go 48.34% <0%> (-15.17%) ⬇️
pdf/ps/exec.go 62.96% <0%> (-14.82%) ⬇️
pdf/ps/operations.go 53.45% <0%> (-13.84%) ⬇️
pdf/model/signature_handler.go 55.04% <0%> (-13.77%) ⬇️
pdf/core/stream.go 31.08% <0%> (-13.52%) ⬇️
pdf/extractor/image.go 66.08% <0%> (-13.05%) ⬇️
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82a1d32...74ff7f9. Read the comment docs.

@gunnsth gunnsth merged commit d641dd8 into unidoc:v3 Apr 9, 2019
@adrg adrg deleted the subtable-row-height branch April 9, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants