Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add split e2e test with memory checking [v3] #410

Merged
merged 1 commit into from
Apr 13, 2019
Merged

Conversation

gunnsth
Copy link
Contributor

@gunnsth gunnsth commented Apr 13, 2019

The split test reads and writes back out a single page from each test file.
Tests the efficiency of working with parts of large files.
Checks the hash of the output to avoid regressions.
Measures duration and memory allocations.

The split test measures duration and memory allocations.
@gunnsth gunnsth added this to the v3.0.0-rc.1 milestone Apr 13, 2019
@codecov
Copy link

codecov bot commented Apr 13, 2019

Codecov Report

Merging #410 into v3 will decrease coverage by 5.32%.
The diff coverage is 86.2%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #410      +/-   ##
==========================================
- Coverage   60.96%   55.63%   -5.33%     
==========================================
  Files         151      153       +2     
  Lines       27502    27531      +29     
==========================================
- Hits        16767    15318    -1449     
- Misses      10319    10345      +26     
- Partials      416     1868    +1452
Impacted Files Coverage Δ
pdf/internal/e2etest/memory_measure.go 100% <100%> (ø)
pdf/internal/e2etest/utils.go 60% <60%> (ø)
pdf/core/security/handlers.go 33.33% <0%> (-16.67%) ⬇️
pdf/model/optimize/image_ppi.go 59.7% <0%> (-16.42%) ⬇️
pdf/model/reader.go 48.34% <0%> (-15.17%) ⬇️
pdf/ps/exec.go 62.96% <0%> (-14.82%) ⬇️
pdf/ps/operations.go 53.45% <0%> (-13.84%) ⬇️
pdf/model/signature_handler.go 55.04% <0%> (-13.77%) ⬇️
pdf/core/stream.go 31.08% <0%> (-13.52%) ⬇️
pdf/extractor/image.go 66.08% <0%> (-13.05%) ⬇️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea91b30...5871532. Read the comment docs.

@gunnsth gunnsth merged commit 852b515 into v3 Apr 13, 2019
@gunnsth gunnsth deleted the v3-add-split-e2e-test branch April 13, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant