Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Pages dict Type if not set #419

Merged
merged 3 commits into from
Apr 17, 2019
Merged

Set Pages dict Type if not set #419

merged 3 commits into from
Apr 17, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Apr 17, 2019

Addresses #416

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (v3@ca4f19e). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##             v3     #419   +/-   ##
=====================================
  Coverage      ?   59.51%           
=====================================
  Files         ?      153           
  Lines         ?    27683           
  Branches      ?        0           
=====================================
  Hits          ?    16475           
  Misses        ?    10836           
  Partials      ?      372
Impacted Files Coverage Δ
pdf/model/reader.go 65.43% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca4f19e...c6feed4. Read the comment docs.

@gunnsth gunnsth merged commit d34ba3c into unidoc:v3 Apr 17, 2019
@adrg adrg deleted the pages-type-missing branch April 18, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants