Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contentstream package golint notices #422

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Fix contentstream package golint notices #422

merged 2 commits into from
Apr 17, 2019

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Apr 17, 2019

Fix golint notices in the contentstream package.
Addresses #421

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #422 into v3 will increase coverage by <.01%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #422      +/-   ##
==========================================
+ Coverage   54.37%   54.38%   +<.01%     
==========================================
  Files         153      153              
  Lines       27680    27677       -3     
==========================================
+ Hits        15050    15051       +1     
+ Misses      10834    10830       -4     
  Partials     1796     1796
Impacted Files Coverage Δ
pdf/contentstream/processor.go 50.3% <ø> (ø) ⬆️
pdf/contentstream/inline-image.go 33.97% <50%> (-0.13%) ⬇️
pdf/contentstream/parser.go 65.53% <79.16%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03319e6...743be00. Read the comment docs.

@gunnsth gunnsth merged commit ca4f19e into unidoc:v3 Apr 17, 2019
@adrg adrg deleted the contentstream-golint branch April 18, 2019 15:41
@adrg adrg mentioned this pull request Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants