Cross reference search speed improvements [v3] #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed to empty struct to reduce allocations.
Codecov Report
@@ Coverage Diff @@
## v3 #424 +/- ##
==========================================
- Coverage 59.56% 59.53% -0.03%
==========================================
Files 153 153
Lines 27683 27707 +24
==========================================
+ Hits 16489 16495 +6
- Misses 10807 10836 +29
+ Partials 387 376 -11
Continue to review full report at Codecov.
|
adrg
reviewed
Apr 18, 2019
pdf/core/parser.go
Outdated
| parser.xrefs[objNum] = obj | ||
| common.Log.Trace("entry: %+v", parser.xrefs[objNum]) | ||
| parser.xrefs.ObjectMap[objNum] = obj | ||
| common.Log.Trace("entry: %+v", parser.xrefs.ObjectMap[objNum]) |
There was a problem hiding this comment.
Maybe just print obj instead of reading it from the map after adding it:
common.Log.Trace("entry: %+v", obj)
| } | ||
|
|
||
| i := sort.Search(len(parser.xrefs.sortedObjects), func(i int) bool { |
There was a problem hiding this comment.
This seems to be equivalent to:
for _, obj := range parser.xrefs.sortedObjects {
if obj.Offset >= offset {
return obj.Offset
}
}
return 0
There was a problem hiding this comment.
Yes, except sort.Search uses binary search which is very efficient for sorted data.
pdf/core/parser.go
Outdated
| } | ||
|
|
||
| // Sort by offset, descending. |
There was a problem hiding this comment.
Seems to be ascending offset order.
…nidoc into v3-xref-perf-improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two notable performance enhancements:
Changes required changing XrefTable to a struct to be able to add the cached list of objects for faster search.
The changes speed up passthrough benchmark test in the build server from 38-40seconds down to 15 seconds, so it's a pretty significant improvement.