Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten fixes #368

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Flatten fixes #368

merged 2 commits into from
Jan 31, 2020

Conversation

zgordan-vv
Copy link
Contributor

@zgordan-vv zgordan-vv commented Jan 30, 2020 •
edited by gunnsth
Loading

This change is Reviewable

@zgordan-vv zgordan-vv changed the title Flatten fixes WIP: Flatten fixes Jan 30, 2020
gunnsth
gunnsth reviewed Jan 30, 2020
View reviewed changes
spreadsheet/context.go Outdated
@@ -233,6 +233,7 @@ func (e *evalContext) LastRow(col string) int {
var refRegexp *regexp.Regexp = regexp.MustCompile(`^([a-z]+)([0-9]+)$`)

func validateRef(cr string) bool {
cr = strings.ReplaceAll(cr, "$", "")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check build errors:

github.com/unidoc/unioffice/spreadsheet

../../../spreadsheet/context.go:236:7: undefined: strings.ReplaceAll

I think ReplaceAll is new, better use Replace with -1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@codecov
Copy link

codecov bot commented Jan 31, 2020 •
edited
Loading

Codecov Report

Merging #368 into master will decrease coverage by 0.52%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
- Coverage    55.2%   54.68%   -0.53%     
==========================================
  Files         207      207              
  Lines       18083    18094      +11     
==========================================
- Hits         9983     9894      -89     
- Misses       7123     7223     +100     
  Partials      977      977
Impacted Files Coverage Δ
spreadsheet/formula/def_eval.go 85.71% <ø> (-1.25%) ⬇️
spreadsheet/context.go 0% <0%> (ø) ⬆️
spreadsheet/row.go 69.76% <85.71%> (+2.19%) ⬆️
spreadsheet/formula/fnstatistical.go 73.57% <0%> (-7.11%) ⬇️
spreadsheet/formula/fnmathtrig.go 72.91% <0%> (-3.2%) ⬇️
spreadsheet/formula/lexer.go 33.18% <0%> (-1.66%) ⬇️
spreadsheet/formula/fnindex.go 61.28% <0%> (-1.45%) ⬇️
spreadsheet/formula/fntext.go 69.03% <0%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5ef37c...c821695. Read the comment docs.

@zgordan-vv zgordan-vv changed the title WIP: Flatten fixes Flatten fixes Jan 31, 2020
gunnsth
gunnsth approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit 215a2d2 into unidoc:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnsth gunnsth gunnsth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zgordan-vv @gunnsth