Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form fill fixes #328

Merged
merged 4 commits into from Apr 24, 2020
Merged

Form fill fixes #328

merged 4 commits into from Apr 24, 2020

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Apr 24, 2020

  • Account for child fields with embedded widget annotations when parsing forms.
  • Use default font when generating annotation appearances, if the appearance font is not found.
  • Match fields using both partial and full field name when filling forms.
  • Add JSON extract and fill test case.

Related to #326.


This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #328 into development will decrease coverage by 0.08%.
The diff coverage is 73.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #328      +/-   ##
===============================================
- Coverage        62.37%   62.28%   -0.09%     
===============================================
  Files              236      236              
  Lines            45591    45578      -13     
===============================================
- Hits             28438    28390      -48     
- Misses           16489    16539      +50     
+ Partials           664      649      -15     
Impacted Files Coverage Δ
model/form.go 66.84% <60.00%> (+1.10%) ⬆️
annotator/field_appearance.go 55.62% <83.33%> (-0.17%) ⬇️
model/fields.go 65.63% <100.00%> (+2.35%) ⬆️
creator/creator.go 75.92% <0.00%> (-5.30%) ⬇️
model/writer.go 80.39% <0.00%> (-4.45%) ⬇️
model/reader.go 61.12% <0.00%> (ø)
fjson/fielddata.go 90.66% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb0166e...d8b9176. Read the comment docs.

@adrg adrg changed the base branch from master to development April 24, 2020 16:04
Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit d84d0c4 into unidoc:development Apr 24, 2020
@adrg adrg deleted the form-fill-issues branch April 27, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants