Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable font fallback options for form fields #368

Merged
merged 8 commits into from
Jun 9, 2020
Merged

Add configurable font fallback options for form fields #368

merged 8 commits into from
Jun 9, 2020

Conversation

adrg
Copy link
Collaborator

@adrg adrg commented Jun 5, 2020

  • Add global font fallback option for fields with invalid or not specified fonts in their DA stream
  • Add font fallback per form field option
  • Add option to force font replacement when filling/flattening form fields

This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #368 into development will decrease coverage by 3.80%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #368      +/-   ##
===============================================
- Coverage        56.51%   52.71%   -3.81%     
===============================================
  Files              236      236              
  Lines            45825    45786      -39     
===============================================
- Hits             25899    24137    -1762     
- Misses           16588    18540    +1952     
+ Partials          3338     3109     -229     
Impacted Files Coverage Δ
annotator/field_appearance.go 11.24% <0.00%> (-38.83%) ⬇️
internal/jbig2/globals.go 0.00% <0.00%> (-100.00%) ⬇️
internal/e2etest/memory_measure.go 0.00% <0.00%> (-100.00%) ⬇️
internal/jbig2/decode.go 0.00% <0.00%> (-70.00%) ⬇️
internal/e2etest/validate.go 0.00% <0.00%> (-70.00%) ⬇️
model/flatten.go 0.00% <0.00%> (-64.23%) ⬇️
internal/e2etest/utils.go 0.00% <0.00%> (-60.00%) ⬇️
contentstream/processor.go 16.91% <0.00%> (-34.14%) ⬇️
internal/jbig2/decoder/decoder.go 0.00% <0.00%> (-26.93%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5777ee1...a213051. Read the comment docs.

Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit 6cb58f6 into unidoc:development Jun 9, 2020
@adrg adrg deleted the form-fill-font-fallbacks branch June 9, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants