add --float-precision option, fix duplicateUFO and add more tests #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 8, 2016 17:56
Default is 10 decimal places. Value of -1 means no rounding: i.e. use built-in repr() Also, backport tempfile.TemporaryDirectory to python 2.7 (can be useful for tests)
otherwise, copytree raises FileNotFoundError
anthrotype
changed the title
|
I just removed the commit about ignoring the timestamps (and changed the title of the pull request). I left the other commits (which is minor stuff anyway). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timestamps sometimes may change even though the content of files does not (e.g. the file is 'touched' but not modified). I don't like when git detect changes in lib.plist only because the timestamps have changed, but the content isn't. Git itself tracks changes using hashes rather than timestamps, and can tell me exactly the list of files which have been modified.
So when I keep a UFO under version control, I want to be able to tell the normalizer to not store the timestamps.
In a follow-up PR, I'll add a
--subpathsoption that applies the normalization only to the specified set of files. The latter can be used in conjunction with--no-modtimesto pass the ufonormalizer the list of files modified as pergit diff --name-only.In addition, the current PR adds
--float-precisioncommand line option. The special value of-1means no rounding (i.e.,repr()).