ufonormalizer: store modTimes and imageReferences in layerInfo's "lib"... #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…", not in top-level dict http://www.unifiedfontobject.org/versions/ufo3/glyphs.html#layerinfo According to the UFO3 spec, the layerinfo.plist data is a dictionary containing "color" definition and a "lib" sub-dictionary. The ufonormalizer was confusing the top-level dictionary with the lib dictionary, and overwriting the former with the content of the latter. Instead, modTimes and imageReferences must be read/written from/in the inner "lib" dict of layerinfo.plist. Later on, we should write tests for this, as well as the whole `normalizeGlyphsDirectory` function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and not in the top-level dict.
According to the UFO3 spec, the "layerinfo.plist" data is a dictionary containing a "color" definition and a "lib" sub-dictionary.
The ufonormalizer was confusing the top-level dictionary with the inner lib dictionary, and was overwriting the former with the content of the latter!
Instead, the "modTimes" and "imageReferences" keys must be read/written from/in the inner "lib" dict of layerinfo.plist file.
Later on, we shall also write tests for this, as well as for the whole
normalizeGlyphsDirectoryfunction.