Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ufonormalizer: store modTimes and imageReferences in layerInfo's "lib"... #35

Merged
merged 1 commit into from
Apr 21, 2016
Merged

ufonormalizer: store modTimes and imageReferences in layerInfo's "lib"... #35

merged 1 commit into from
Apr 21, 2016

Commits on Apr 21, 2016

  1. ufonormalizer: store modTimes and imageReferences in layerInfo's "lib… 

    …", not in top-level dict

http://www.unifiedfontobject.org/versions/ufo3/glyphs.html#layerinfo

According to the UFO3 spec, the layerinfo.plist data is a dictionary containing "color" definition and a "lib" sub-dictionary. The ufonormalizer was confusing the top-level dictionary with the lib dictionary, and overwriting the former with the content of the latter.
Instead, modTimes and imageReferences must be read/written from/in the inner "lib" dict of layerinfo.plist.

Later on, we should write tests for this, as well as the whole `normalizeGlyphsDirectory` function.
    Cosimo Lupo committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    a0b9d92 View commit details
    Browse the repository at this point in the history