file.cwd is not correctly set

[wooorm]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions

latest

Link to runnable example

No response

Steps to reproduce

cwd is not set when creating a file or when creating an engine.

file.cwd must be set to the folder that is the “workplace”, e.g., the place where the package.json and .git are typically.
Right now, it’s not set, so it’s (90% sure) set to a wrong value. Which means certain plugins break (example: https://github.com/remarkjs/remark-usage/blob/ae591a38bfb5424a802f25ae77b69f5dc06836fa/lib/index.js#L13-L27)

Expected behavior

Here’s how I found a logical one for atom: https://github.com/unifiedjs/unified-engine-atom/blob/605326d08a6d04b66aa8abf3143313f24c507699/index.js#L44-L53

Actual behavior

(unknown behavior, likely broken plugins or unexpected results)

Runtime

No response

Package manager

No response

OS

No response

Build and bundle tools

No response

[remcohaszing]

Isn’t it set to process.cwd() by default? Typically the client determines the cwd.

Also does it make sense if unified-engine detects this? I imagine a good cwd to set would be the directory containing the configuration file.

[wooorm]

Yes, but the value provided by process.cwd does not always make sense.
Atom sets it to / (which is why remark-parse can’t be resolved and why linter-remark doesn’t work with the PR)
I’m also guessing the Node.js language server runs in a cwd that is different from the “workspace”, as they‘re separate processed?

unified-engine has an option for it: options.cwd, which can be given the CWD. This can (should?) be set too.

I imagine a good cwd to set would be the directory containing the configuration file.

Files are found first, configuration files are found from them. That means that there can be a) multiple configuration files, b) none, c) one in say, /Users/

[ChristianMurphy]

Maybe the workspace folders(s) could be used? https://microsoft.github.io/language-server-protocol/specifications/specification-3-17/#workspace_workspaceFolders

[wooorm]

Nice that LSP also has that. For Atom, the earlier linked lines (https://github.com/unifiedjs/unified-engine-atom/blob/605326d08a6d04b66aa8abf3143313f24c507699/index.js#L44-L53) uses something like that too.

[remcohaszing]

Yes, I think using rootUri of the InitializeParams should be used.