Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure input URIs don’t change #38

Closed
4 tasks done
wooorm opened this issue Mar 18, 2022 · 2 comments · Fixed by #40
Closed
4 tasks done

Make sure input URIs don’t change #38

wooorm opened this issue Mar 18, 2022 · 2 comments · Fixed by #40
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem

Comments

@wooorm
Copy link
Member

wooorm commented Mar 18, 2022

Initial checklist

Problem

Input and output file URIs sometimes don‘t match. E.g.,:

While your problem currently presents itself around symlinks, it might not be a problem unique to symlinks (e.g., there might be other values that are sent which are sent back differently, due to escapes/encoding of characters, slashes, case-sensitive/-insensitive file systems, &c.).

(GH-32).

Solution

For a solution, I think we can solve this quite like what you’re currently doing it. But I dislike the name file.data.uri. And commenting about symlinks only.
What about calling it file.data.lspInputUri or so? To signal that its purpose is to pass a certain string from that protocol through the engine and back?

lspDocumentUri is great, yeah! I like it more than lspInputUri

(GH-32).

Alternatives

n/a

@wooorm wooorm added 🐛 type/bug This is a problem help wanted 🙏 This could use your insight or help good first issue 👋 This may be a great place to get started! 🗄 area/interface This affects the public interface 👶 semver/patch This is a backwards-compatible fix 👍 phase/yes Post is accepted and can be worked on labels Mar 18, 2022
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@wooorm wooorm added the 💪 phase/solved Post is done label Apr 1, 2022
@github-actions github-actions bot removed 👍 phase/yes Post is accepted and can be worked on help wanted 🙏 This could use your insight or help good first issue 👋 This may be a great place to get started! labels Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Development

Successfully merging a pull request may close this issue.

1 participant