Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use unist-util-lsp #56

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Refactor to use unist-util-lsp #56

merged 1 commit into from
Jun 1, 2023

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

This replaces conversion functions for unist positions to language server ranges with unist-util-lsp.

@remcohaszing remcohaszing added 🦋 type/enhancement This is great to have 📦 area/deps This affects dependencies 🏡 area/internal This affects the hidden internals 👶 semver/patch This is a backwards-compatible fix 🤞 phase/open Post is being triaged manually labels Jun 1, 2023
@remcohaszing
Copy link
Member Author

Since this just changes internals, IMO no release is needed.

@wooorm wooorm changed the title Use unist-util-lsp Refactor to use unist-util-lsp Jun 1, 2023
@wooorm wooorm merged commit 979b4eb into main Jun 1, 2023
14 checks passed
@wooorm wooorm deleted the unist-util-lsp branch June 1, 2023 10:54
@wooorm wooorm added the 💪 phase/solved Post is done label Jun 1, 2023
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

@ChristianMurphy ChristianMurphy Awaiting requested review from ChristianMurphy

Assignees
No one assigned
Labels
📦 area/deps This affects dependencies 🏡 area/internal This affects the hidden internals 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@remcohaszing @wooorm