Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle unified-engine errors #63

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

remcohaszing
Copy link
Member

Closes #24

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Errors from unified-engine are reported as diagnostics on the files the error occurred on. Previously errors were simply unhandled.

@remcohaszing remcohaszing added 🦋 type/enhancement This is great to have 🗄 area/interface This affects the public interface 🧒 semver/minor This is backwards-compatible change 🤞 phase/open Post is being triaged manually labels Sep 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c3023e7) 100.00% compared to head (ec4d47d) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #63   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          558       558           
=========================================
  Hits           558       558           
Files Changed Coverage Δ
lib/index.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remcohaszing remcohaszing merged commit 9ab5368 into main Sep 5, 2023
12 of 13 checks passed
@remcohaszing remcohaszing deleted the handle-unified-engine-errors branch September 5, 2023 11:18
@github-actions

This comment has been minimized.

@wooorm wooorm added the 💪 phase/solved Post is done label Sep 5, 2023
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

Add test for broken config
3 participants