add typescript types, continued #8
Merged
+347
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- test now imports itself as a package (neat!) - dtslint checks the types are pretty - `typescript` and `unist-util-is` moved to devdeps (should have been before) - maybe this is known, but weirdly this package depends on an older version of itself through remark-preset-wooorm
- remember to add tslint.json
also: * removes nullish * adds comments * adds more type tests * clarifies which props can be used with reset
typings: refactor to support unified
ensures generic carries through, and verifies with mdast and hast types
ChristianMurphy
added
🦋 type/enhancement
This comment has been minimized.
This comment has been minimized.
ChristianMurphy
commented
Jan 27, 2020
ChristianMurphy
added
the
🌊 blocked/upstream
ChristianMurphy
removed
the
🌊 blocked/upstream
|
Thanks! LGTM but I‘d like a review from someone else as well before landing |
wooorm
approved these changes
Jan 30, 2020
|
Released as 3.0.0, thanks @ChristianMurphy, @Zemnmez, and @Rokt33r! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #7 with some additional tests